Refactor nf-core modules commands
#1124
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #1124 +/- ##
==========================================
+ Coverage 70.41% 70.58% +0.16%
==========================================
Files 45 48 +3
Lines 4797 4827 +30
==========================================
+ Hits 3378 3407 +29
- Misses 1419 1420 +1
Continue to review full report at Codecov.
|
|
Hi @ErikDanielsson , overall I think this is a nice idea! One thing that is a bit tricky with the modules commands though is that some of them (mostly But other than that I think this is nice! But would be nice to hear what @ewels thinks about this :) |
|
Thanks, I'll take a look at the lint code. |
nf_core/modules/install.py
Outdated
| def install(self, module): | ||
| if self.repo_type == "modules": | ||
| log.error("You cannot install a module in a clone of nf-core/modules") | ||
| sys.exit(1) |
There was a problem hiding this comment.
Can we raise an exception instead and catch it in the cli code? I prefer not to have exits anywhere but there if possible.
There was a problem hiding this comment.
Other checks just return false. So that would also be fine.
Refactored
pipeline_modules.pyinto one file file pernf-core modulescommand.pipeline_modules.pyModuleCommandformodulescommands to inherit from.list,installandremovecommands.The
modulescommands are all now found in<command>.py.PR checklist
CHANGELOG.mdis updateddocsis updated